D9167: Improve string handling

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Dec 12 00:57:25 UTC 2017


apol marked 2 inline comments as done.
apol added a comment.


  Thanks!

INLINE COMMENTS

> dhaumann wrote in kiconeffect.cpp:165
> Previously, this was not an else if(), but just an if().
> 
> Are you sure this works as intended?

Yes, `effectGroupState` is not going to change values out of the blue.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D9167

To: apol, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171212/909e0234/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list