D9257: MessageInterface: Add CenterInView as additional position
Dominik Haumann
noreply at phabricator.kde.org
Fri Dec 8 15:29:29 UTC 2017
dhaumann created this revision.
dhaumann added reviewers: cullmann, neundorf.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the message interface to support CenterInView.
This should be binary compatible, since an enum is only added at
the end.
The search messages "Search wrapped at bottom/top" now use
CenterInView to be more visible (see recent discussion on
kwrite-devel). In order to support his, a custom layout called
KateMessageLayout was added that only supports the positions
allowed by KTextEditor::Messate::MessagePosition.
TEST PLAN
make test, manual testing
REPOSITORY
R39 KTextEditor
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9257
AFFECTED FILES
src/include/ktexteditor/message.h
src/search/katesearchbar.cpp
src/search/katesearchbar.h
src/view/kateview.cpp
src/view/kateview.h
src/view/kateviewhelpers.cpp
src/view/kateviewhelpers.h
To: dhaumann, cullmann, neundorf
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171208/faac3e72/attachment.html>
More information about the Kde-frameworks-devel
mailing list