D9217: KUriFilter: don't return an error on non-existing files.

Dominik Haumann noreply at phabricator.kde.org
Wed Dec 6 21:53:13 UTC 2017


dhaumann added a comment.


  I was just testing this. With this patch, a non-existing ~/test:
  
  1. Dolphin goes to /home/dh/test, and a red box tells the folder does not exist. This is better than the protocol-error message, so https://bugs.kde.org/show_bug.cgi?id=372813 should be fixed.
  2. In the file open-dialog: This expands also to /home/dh/test, but does not raise an error. So the contents of the listview remains the same.
  
  In summary:
  
  1. is certainly better with this patch.
  2. file open dialog was possibly better without this patch, since "~/home" <enter> resulted in "/" and not silently in some location that does not exist. This should probably be improved in the file-open dialog itself?
  
  All in all, this patch is an improvement.

REVISION DETAIL
  https://phabricator.kde.org/D9217

To: dfaure, emateli, elvisangelaccio, gregormi
Cc: dhaumann, broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171206/34b1c04d/attachment.html>


More information about the Kde-frameworks-devel mailing list