D8450: User can now hide an entire places group from KFilePlacesView

Milian Wolff noreply at phabricator.kde.org
Wed Dec 6 12:26:15 UTC 2017


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  one minor nit, otherwise lgtm

INLINE COMMENTS

> kfileplacesmodel.cpp:431
> +    QModelIndexList indexes;
> +    for (int row = 0; row < rowCount(); ++row) {
> +        const QModelIndex current = index(row, 0);

only call rowCount once:

  for (int row = 0, c = rowCount(); row < c; ++row) {

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171206/f04542bf/attachment.html>


More information about the Kde-frameworks-devel mailing list