D8920: Fixes url navigation with relative links on KUrlNavigator
David Faure
noreply at phabricator.kde.org
Tue Dec 5 21:11:52 UTC 2017
dfaure added inline comments.
INLINE COMMENTS
> kurlnavigator.cpp:1009
> + // Always expand starting ~/ to $HOME. We want all inputs starting with it to point home directory.
> + // The reason this expansion is performed here, is that kshorturifilter will not return the desired result
> + // if said directory does not exist.
This is written like kshorturifilter is buggy...
I looked into it to see if there was a good reason why kshorturifilter returns Error in case of a non-existing local path, but in fact.... it doesn't really have to.
If the user types a non-existing path in a URL bar then opening that path will error anyway, there's no need to catch that at the kurifilter level.
I'm working on a fix for kshorturifilter.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171205/63e26481/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list