D9205: QStringList initializer list cleanup

Milian Wolff noreply at phabricator.kde.org
Tue Dec 5 17:18:43 UTC 2017


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  yep this is better than before after all

INLINE COMMENTS

> kateview.cpp:1385
>  
> -    QStringList l;
> -
> -    l << QStringLiteral("edit_replace")
> -      << QStringLiteral("tools_spelling")
> -      << QStringLiteral("tools_indent")
> -      << QStringLiteral("tools_unindent")
> -      << QStringLiteral("tools_cleanIndent")
> -      << QStringLiteral("tools_align")
> -      << QStringLiteral("tools_comment")
> -      << QStringLiteral("tools_uncomment")
> -      << QStringLiteral("tools_toggle_comment")
> -      << QStringLiteral("tools_uppercase")
> -      << QStringLiteral("tools_lowercase")
> -      << QStringLiteral("tools_capitalize")
> -      << QStringLiteral("tools_join_lines")
> -      << QStringLiteral("tools_apply_wordwrap")
> -      << QStringLiteral("tools_spelling_from_cursor")
> -      << QStringLiteral("tools_spelling_selection");
> +    static const QStringList l {
> +          QStringLiteral("edit_replace")

this could still be an initializer list

REPOSITORY
  R39 KTextEditor

BRANCH
  QStringListCleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9205

To: dhaumann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171205/069ab6be/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list