D9168: Migrate some QRegExps to QRegularExpression

Dominik Haumann noreply at phabricator.kde.org
Tue Dec 5 11:59:38 UTC 2017


dhaumann marked an inline comment as done.
dhaumann added a comment.


  Update patch.

INLINE COMMENTS

> mwolff wrote in katecmds.cpp:502
> static?

I do not think static is needed here: When you invoke the command line (F7), and type 'char 0x123', then creating a QRegularExpression will not be a bottleneck.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9168

To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171205/cdac7bec/attachment.html>


More information about the Kde-frameworks-devel mailing list