D9182: return nullptr -> return {} for QFlags

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Dec 4 18:36:42 UTC 2017


kossebau added a comment.


  Code change looks good to me. Think I missed that in my clean-up commits to @kfunk 's initial commit as I only compiled the library parts of KDE Frameworks, not the plugin modules.
  
  No maintainer of this module though, so just a +1 for now.
  
  Commit message could perhaps be extended to quickly note why the nullptr has been there at all, so future commit history readers get a clue, which they do not from a "irritating" attribution :)

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D9182

To: mkoller, kfunk, kossebau
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171204/8c5c0798/attachment.html>


More information about the Kde-frameworks-devel mailing list