D8254: Make file ioslave backend on removeables are user-frendly on linux

Oswald Buddenhagen noreply at phabricator.kde.org
Sun Dec 3 13:58:53 UTC 2017


ossi added inline comments.

INLINE COMMENTS

> file_unix.cpp:241
>      QFile dest_file(dest);
> -    if (!dest_file.open(QIODevice::Truncate | QIODevice::WriteOnly)) {
> +    int dest_fd = ::open(dest.toStdString().c_str(), O_CREAT | O_TRUNC | (is_removeable? O_SYNC : 0) | O_WRONLY);
> +    if (!dest_file.open(dest_fd, QIODevice::Truncate | QIODevice::WriteOnly, QFile::AutoCloseHandle)) {

you want O_DSYNC

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8254

To: vova7890, #frameworks, dfaure, ossi, thiago
Cc: dfaure, ngraham, alexeymin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171203/67c22db2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list