D9128: [knewstuff] Respect global variable

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: leinir, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  If engine is a part of global allocated object d_func *potentially* can be freed before engine, it will cause a crash in such application.
  getCache has a 2 potential problems:
  
  1. s_caches can significantly increase its size
  2. call after destroyed shared pointer will return a nullptr

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D9128

AFFECTED FILES
  src/core/cache.cpp
  src/core/engine.cpp

To: anthonyfieroni, leinir, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171203/51980e03/attachment.html>