D9103: Add BatchRenameJob to KIO
Chinmoy Ranjan Pradhan
noreply at phabricator.kde.org
Sat Dec 2 18:04:18 UTC 2017
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in batchrenamejob.cpp:196
> Ah right KIO::moveAs itself pops up the overwrite dialog, but then can it end with KIO::ERR_FILE_ALREADY_EXIST ? At that point the user should overwrite or skip or cancel. Are you really sure this error code can happen in this slot?
If the job isn't interactive (like in unit test) then it ends with ERR_FILE_ALREADY_EXIST error. In case of unit test ignoring the error seems quite harmless.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/c2880c50/attachment.html>
More information about the Kde-frameworks-devel
mailing list