D9109: Performance

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> packageurlinterceptor.cpp:166
> +        const int firstSlash = relativePath.indexOf(QLatin1Char('/'));
> +        const QString filename = firstSlash >= 0 && firstSlash < relativePath.size() ? relativePath.mid(firstSlash + 1) : relativePath;
> +        const QUrl ret = QUrl::fromLocalFile(package.filePath(prefixForType(type, filename), filename));

Should be 'firstSlash < (relativePath.size() - 1)'?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9109

To: apol, #frameworks, #plasma
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/7b3919e3/attachment.html>