Review Request 129381: kconfig fix kconfigskeletontest

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/
-----------------------------------------------------------

(Updated Aug. 30, 2017, 4:08 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kconfig


Description
-------

some kconfigskeletontest tests were failing. this patch fixes:

1) rename init() and cleanup() to initTestCase() and cleanupTestCase() by convention and to make sure they happen in the correct order
2) testRemoveItem() must come after testKConfigDirty() becuase it removes the item we test for dirtyness
3) fix testSaveRead()


Diffs
-----

  autotests/kconfigskeletontest.h 5cdcc9d 
  autotests/kconfigskeletontest.cpp 898366c 

Diff: https://git.reviewboard.kde.org/r/129381/diff/


Testing
-------

before some of the tests fail and now they all pass.


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170830/e2cf0b97/attachment.html>