D7584: [Icon Item] Don't needlessly unset imagePath

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> iconitem.cpp:199
>                  if (!iconPath.isEmpty()) {
>                      m_svgIcon->setImagePath(iconPath);
>                      m_svgIconName = sourceString;

are you saying we'll always hit this one?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7584

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170830/730aab4c/attachment.html>