D7337: Port rest of scripting API to QJSValue-based solution

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Looks ok for me.
  
  To shorten the code, I would have used
  
  const auto cursor = cursorFromScriptValue(jscursor);
  
  at most places, but that is taste, the explicit type makes more clear what the type is ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7337

To: dhaumann, carewolf, cullmann
Cc: kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170826/d4d87d13/attachment.html>