D7529: KIO: fix long-standing memory leak on exit.
David Faure
noreply at phabricator.kde.org
Thu Aug 24 23:03:12 UTC 2017
dfaure updated this revision to Diff 18724.
dfaure added a comment.
- Fix leak introduced by first version of the commit, we need to make a copy of the idle list before clearing it.
- When deleting the slave because it emits a signal, we still need to use deleteLater(), I guess...
The slaveDied() code path isn't unittested, which is why I didn't detect this earlier.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7529?vs=18722&id=18724
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7529
AFFECTED FILES
src/core/scheduler.cpp
src/core/scheduler_p.h
src/core/slave.cpp
src/core/slave.h
To: dfaure, mwolff
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170824/fc09b508/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list