D7527: Add mimetype filtering capabilities to KUrlCompletion

Milian Wolff noreply at phabricator.kde.org
Thu Aug 24 20:45:56 UTC 2017


mwolff added a comment.


  Note that the test passes, but I noticed that the KURLCOMPLETION_LOCAL_KIO branch is not covered by unit tests. Setting it even shows that the test is then broken (even without this patch).
  
  Also, creating a new thread for every completion request is not a good idea. This code severly needs a cleanup to use QThreadPool (i.e. via QtConcurrent)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7527

To: mwolff, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170824/716b3631/attachment.html>


More information about the Kde-frameworks-devel mailing list