D7462: [kiocore] assert that klauncher is running or not

Bhushan Shah noreply at phabricator.kde.org
Thu Aug 24 04:52:01 UTC 2017


bshah marked an inline comment as done.
bshah added inline comments.

INLINE COMMENTS

> dfaure wrote in slave.cpp:111
> } else if (...) {
> 
> We don't want/need to turn reply into a bool if it's not valid.
> 
> Alternatively this could be written as
> 
>   if (!reply.isValid() || getuid() != reply) // not running, or owned by a different user
> 
> but I don't mind either way.

somehow arc diff is failing on me to update this change's summary and description.. I will commit this change and summary change .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7462

To: bshah, #frameworks, sitter, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170824/d58d7e08/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list