D7462: [kiocore] assert that klauncher is running or not

[David Faure]

dfaure added a comment.


  Makes sense.

INLINE COMMENTS

> slave.cpp:111
> +            // fallback: if there's an klauncher process owned by a different user: still fork
> +            if (getuid() != reply) {
>                  fork = true;

} else if (...) {

We don't want/need to turn reply into a bool if it's not valid.

Alternatively this could be written as

  if (!reply.isValid() || getuid() != reply) // not running, or owned by a different user

but I don't mind either way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7462

To: bshah, #frameworks, sitter, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170823/95fea84e/attachment.html>