D7164: KSqueezedTextLabel: Respect indent, margin and frame width
Dominik Haumann
noreply at phabricator.kde.org
Tue Aug 22 20:14:27 UTC 2017
dhaumann added a subscriber: cfeck.
dhaumann added a comment.
To me this looks good.
It seems Q_PROPERTYs can be overridden (at least, this follows imho from "The presence of the FINAL attribute indicates that the property will not be overridden by a derived class" from http://doc.qt.io/qt-5/properties.html). That we should be fine.
@cfeck A second review would be appreciated.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7164
To: rkflx, #frameworks
Cc: cfeck, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170822/b518663e/attachment.html>
More information about the Kde-frameworks-devel
mailing list