D7458: Show icons in icon border context menu

[Kevin Funk]

kfunk added a comment.


  Other than that the patch looks sensible to me.

INLINE COMMENTS

> kateviewhelpers.cpp:2253
> +                dMA = selectDefaultMark.addAction(m_doc->markDescription(markType));
> +            } else {
> +                mA = markMenu.addAction(icon, m_doc->markDescription(markType));

Less code with:

  if (auto icon = ...) {
      mA->setIcon(icon);
      dMA->setIcon(icon);
  }

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7458

To: croick, #ktexteditor
Cc: kfunk, kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170822/e488e9ad/attachment-0001.html>