D5431: New LESS syntax based on SCSS
Yunhe Guo
noreply at phabricator.kde.org
Mon Aug 21 08:15:12 UTC 2017
guoyunhe added a comment.
In https://phabricator.kde.org/D5431#138044, @dhaumann wrote:
> Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...
That patch is based on my SCSS syntax. Since that has been committed, it will be a hard work to compare and update rules.
In https://phabricator.kde.org/D5431#138041, @cullmann wrote:
> Hi, given I have no real idea about this HL, looks not wrong, but could you add/extend a unit test?
> Then this can go in I would say.
> Thanks for the change!
I do not know how to make unit test. Is here any documentation.
And nowadays I became really busy on work and KDE translation stuff. So I will not have time to check this again. Sorry...
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5431
To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate, cullmann
Cc: dhaumann, cullmann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170821/613f2f6e/attachment.html>
More information about the Kde-frameworks-devel
mailing list