D7380: KCD: use modern logging classes throughout

[René J.V. Bertin]

rjvbb added a comment.


  Some thoughts, I'll update the patch later today.

INLINE COMMENTS

> ltoscano wrote in kcompactdisc_p.cpp:30
> On the other side, this is not a frameworks, but a generic library. I've seen (and pushed) org.kde.<application>[.<subpart>] for applications. What could it be a proper choice here? org.kde.lib.<name>[.<subpart>]? Or simply org.kde.<application>[.<subpart>]?

I see KCalCore does `ecm_qt_declare_logging_category(kcalcore_LIB_SRCS HEADER kcalcore_debug.h IDENTIFIER KCALCORE_LOG CATEGORY_NAME org.kde.pim.kcalcore)`. Note the absence of a `lib` namespace/whatever.
We could thus use `org.kde.kcompactdisc` unless there's already a suitable namespace to which it could be added (multimedia, audio, ...).

> ltoscano wrote in testkcd.cpp:66
> Please don't set this here. It can be controlled at runtime.

I know it can, and I'd agree for regular applications. This is a test application, its users should not have to go figure out why it produces no output and how to make it print something.

You're right though that QT_LOGGING_RULES can already have been set, I can avoid changing it.

> ltoscano wrote in testkcd.cpp:69
> ditto

And ditto: why would you write an application that's supposed to print test results and NOT enable the printing by default? 
(I presume that tests like this would use `QPrint()` if it existed)

REPOSITORY
  R349 KCompactDisc Library

REVISION DETAIL
  https://phabricator.kde.org/D7380

To: rjvbb, #frameworks, davidedmundson, ltoscano
Cc: ltoscano, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170818/d5634680/attachment.html>