D7361: Get rid of QSignalMapper

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Aug 17 09:48:57 UTC 2017


broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Use lambdas instead.

TEST PLAN
  This is slightly faster.
  
  Verified that applet actions are still added and can be triggered.
  Verified that wallpaper actions are still added and can be triggered.
  
  Is it intentional that in AppletInterface removeAction does not remove them from the KActionCollection but only m_actions QStringList? This is only done in the WallpaperInterface.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7361

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170817/e46ed2d1/attachment.html>


More information about the Kde-frameworks-devel mailing list