D6197: Add kauth helper to file ioslave

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filehelper.cpp:34
> +    FdSender fdSender;
> +    fdSender.connectToPath("org_kde_kio_file_helper_socket");
> +    if (fdSender.isConnected()) {

BTW what happens if two instances of this helper (and two instances of kio_file) try to do this at the same time? Don't they need different socket paths, to avoid interferring with each other?

I suppose the PID of the kio_file process should be added to this path, which means passing it in the QVariantMap to exec(), right?

> filehelper.cpp:104
> +        } else {
> +            sendFileDescriptor(-1);
> +        }

You send fd=-1 if opendir fails, but not if dirfd fails.
Is it even needed to send -1, if we're going to return an error reply anyway?
 (disclaimer, I don't know sendFileDescriptor nor what the code on the calling side does)

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170816/38454856/attachment.html>