D7318: KFileItemDelegate: Always reserve space for icons

[Fabian Vogt]

fvogt added a comment.


  The underlying issue is that KIconLoader's implementation of isNull (in virtual_hook) is not really meaningful.
  In cases where a name for a nonexistent icon is passed, pixmap will draw the "unknown" icon, but isNull still returns true.
  
  So the question is whether this is intentional or not. The API doesn't really make that clear.
  
  If isNull should return false iff pixmap returns something other than an empty pixmap, the implementation for KIconLoader
  would probably always return false...
  
  In any case, I still think this diff isn't wrong by itself as the drawing of the pixmap is still unconditional and so should be reflected
  in the text margin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7318

To: fvogt, #frameworks
Cc: cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170815/59a3bccd/attachment.html>