D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

David Edmundson noreply at phabricator.kde.org
Mon Aug 14 10:56:27 UTC 2017


davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Nested classes inherit the visibility of their outer class,
  so all the KClass::Private symbols have also been exported
  if the ones of KClass were.
  
  See also https://phabricator.kde.org/D7279

TEST PLAN
  Ran nm -DC to list symbols
  Only changed visibility of classes defined in .cpp files, so no client code should be affected.

REPOSITORY
  R127 KWayland

BRANCH
  davidedmundson/xdgv6

REVISION DETAIL
  https://phabricator.kde.org/D7304

AFFECTED FILES
  src/client/blur.cpp
  src/client/buffer_p.h
  src/client/compositor.cpp
  src/client/connection_thread.cpp
  src/client/contrast.cpp
  src/client/datadevice.cpp
  src/client/datadevicemanager.cpp
  src/client/dataoffer.cpp
  src/client/datasource.cpp
  src/client/dpms.cpp
  src/client/event_queue.cpp
  src/client/fakeinput.cpp
  src/client/fullscreen_shell.cpp
  src/client/idle.cpp
  src/client/keyboard.cpp
  src/client/output.cpp
  src/client/outputconfiguration.cpp
  src/client/outputdevice.cpp
  src/client/outputmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmodel.cpp
  src/client/pointer.cpp
  src/client/pointerconstraints.cpp
  src/client/pointergestures.cpp
  src/client/region.cpp
  src/client/registry.cpp
  src/client/relativepointer.cpp
  src/client/seat.cpp
  src/client/server_decoration.cpp
  src/client/shadow.cpp
  src/client/shell.cpp
  src/client/shm_pool.cpp
  src/client/slide.cpp
  src/client/subcompositor.cpp
  src/client/subsurface.cpp
  src/client/surface.cpp
  src/client/textinput_p.h
  src/client/touch.cpp
  src/client/xdgshell_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170814/7d191f8b/attachment.html>


More information about the Kde-frameworks-devel mailing list