D7272: [DropJob] Enable drag and drop in a read-only folder

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good otherwise.
  
  (Maybe extend the unittest for dropjob to test the polkit case too?)

INLINE COMMENTS

> dropjob.cpp:107
> +        if (m_flags & KIO::PrivilegeExecution) {
> +            m_flags |= KIO::PrivilegeExecution;
> +            m_privilegeExecutionEnabled = true;

that line is clearly useless, given the line just before.

> dropjob.cpp:151
>      KFileItem m_destItem; // null for remote URLs not found in the dirlister cache
> -    const JobFlags m_flags;
> +    JobFlags m_flags;
>      QList<QAction *> m_appActions;

can be const again, given the above comment

REVISION DETAIL
  https://phabricator.kde.org/D7272

To: chinmoyr, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170813/e933bd0c/attachment.html>