D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[Martin Flöser]

graesslin added a comment.


  > the send_selection spec says we should be passing a null resource if we have no selection, whereas this version creates a data offer with nothing in it.
  
  But we have a selection, that's the point. We just don't have a datasource on the selection.
  
  Relevant code in KWin which goes into the code path:
  
    if (selection) {
                         xclipboard->sendSelection(selection);
                     } else {
                         xclipboard->sendClearSelection();
                     }
  
  We do check whether we have a selection. So from KWayland Server side we have a selection. If we would not have a Selection it would go into sendClearSelection.
  
  That we don't send any useful DataOffer doesn't really matter. We also don't check whether the DataSource has any offers.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170809/8a55bd32/attachment.html>