D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[David Edmundson]

davidedmundson added a comment.


  Isn't the real bug from that trace here:
  
  datadevice_interface.cpp:204
  void DataDeviceInterface::sendSelection(DataDeviceInterface *other)
  d->createDataOffer(other->selection());
  
  it's valid for other->selection() to be null, so this should be guarded there. If I do that your modified unit test passes.
  
  Guarding inside the method I fear will mask future bugs.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170809/5f483294/attachment.html>