D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Aug 8 23:43:31 UTC 2017
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:15
> if(APPLE)
> - target_link_libraries(testtrash "-framework DiskArbitration -framework CoreFoundation")
> + set(testtrash_APPLE_LIBS "-framework DiskArbitration -framework CoreFoundation")
> endif(APPLE)
Note that `target_link_libraries` can still be used with ecm_add_test.
I'd say it's better for readability to use the commands rather than passing cmake variables around.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7213
To: asturmlechner, #frameworks, kfunk
Cc: apol, kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170808/1d230769/attachment.html>
More information about the Kde-frameworks-devel
mailing list