D7163: KSqueezedTextLabel: Add several autotests

Dominik Haumann noreply at phabricator.kde.org
Sun Aug 6 21:09:09 UTC 2017


dhaumann added inline comments.

INLINE COMMENTS

> dhaumann wrote in ksqueezedtextlabelautotest.cpp:217-234
> margin, indent, and lineWidth are all Q_PROPERTYs, maybe you can use QObject::setProperty(const char *, QVariant) to set the values instead of using a function pointer? The function pointer is a bit ugly...
> 
> Example:
> label->setProperty("indent", 40); // will automatically call label->setIndent(40);

Looking at your other change requests: You may want to ignore the note about using setProperty(), since this will call QLabel::setIndent(), and not the one that you add in KSqueezedTextLabel (since setIndent() etc. are not virtual). Maybe this needs further discussion to find the best solution.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7163

To: rkflx, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170806/6d51b761/attachment.html>


More information about the Kde-frameworks-devel mailing list