D6830: Make use of kauth helper in copy method of file ioslave
David Faure
noreply at phabricator.kde.org
Fri Aug 4 20:11:16 UTC 2017
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
The diff has no context in phabricator, which is a problem for this one (e.g. for the "do we need this here?" questions). Can you upload the update using `arc diff` for example?
INLINE COMMENTS
> file_unix.cpp:126
> + if (!execWithElevatedPrivilege(errno, DEL, _dest))
> + error(KIO::ERR_CANNOT_DELETE_ORIGINAL, dest);
> + }
Missing "return;" no?
> file_unix.cpp:176
> + if (!execWithElevatedPrivilege(errno, CHOWN, buff_src.st_uid, buff_src.st_gid)) {
> + error(KIO::ERR_CANNOT_CHOWN, dest);
> + }
missing return;
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6830
To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170804/50a59a87/attachment.html>
More information about the Kde-frameworks-devel
mailing list