D7011: Extract KPasswordLineEdit class
Elvis Angelaccio
noreply at phabricator.kde.org
Thu Aug 3 08:42:06 UTC 2017
elvisangelaccio added inline comments.
INLINE COMMENTS
> mlaurent wrote in knewpasswordwidget.cpp:118
> Nope it's ok as code is called after changing echomode
> I created an autotest for testing it
Then please rename the slot to `_k_echoModeToggled`, otherwise is confusing.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170803/52d4ed79/attachment.html>
More information about the Kde-frameworks-devel
mailing list