D7011: Extract KPasswordLineEdit class

Laurent Montel noreply at phabricator.kde.org
Thu Aug 3 04:42:28 UTC 2017


mlaurent marked 3 inline comments as done.
mlaurent added inline comments.

INLINE COMMENTS

> cfeck wrote in knewpasswordwidget.cpp:118
> Can you double-check this change? To me, the echoMode() checks are now reversed compared to the original code.
> 
> I have not tested the code yet :)

Nope it's ok as code is called after changing echomode
I created an autotest for testing it

REVISION DETAIL
  https://phabricator.kde.org/D7011

To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170803/94105595/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list