D7069: kpackagetool can now write appstream data to a file

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Aug 2 14:32:04 UTC 2017


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

INLINE COMMENTS

> kpackagetool.cpp:473
> +                // Standard value is unprocessed string we'll need to deal with.
> +                object.value("NoDisplay").toString() == QStringLiteral("true") ? true : false) {
> +            std::exit(0);

Why the `? true : false`?

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7069

To: sitter, apol, sebas, mart
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170802/68c2a2a6/attachment.html>


More information about the Kde-frameworks-devel mailing list