D7011: Extract KPasswordLineEdit class

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Aug 2 05:11:42 UTC 2017


kossebau added inline comments.

INLINE COMMENTS

> knewpasswordwidget.ui:88
> +   <class>KPasswordLineEdit</class>
> +   <extends>QLineEdit</extends>
> +   <header>kpasswordlineedit.h</header>

rather extends QWidget now? unsure what exactly the consequences are

> kpassworddialog.ui:163
> +   <class>KPasswordLineEdit</class>
> +   <extends>QLineEdit</extends>
> +   <header>kpasswordlineedit.h</header>

Again QWidget?

> kpasswordlineedit.h:6
> +   modify it under the terms of the GNU Library General Public
> +   License version 2 as published by the Free Software Foundation.
> +

Should this not be rather lgpl2_+_?
see https://community.kde.org/Policies/Licensing_Policy

REVISION DETAIL
  https://phabricator.kde.org/D7011

To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170802/88a1d006/attachment.html>


More information about the Kde-frameworks-devel mailing list