D5674: Solve a visibility conflict for meinproc5
Luigi Toscano
noreply at phabricator.kde.org
Sun Apr 30 21:36:32 UTC 2017
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
This seems to affect only mingw, which can't link meinproc5 as
the symbol exported affects in the sources shared with the
library affects the build (but not on gcc on *nix and with MSVC).
The other (probably better) solution would have been to split the
source code so that the sources of the libraries are separate, but
that would require more changes. As this seems to work, I'd prefer
to move the more complicated changes to "later".
Thanks to Hannah Von Reth for the hint.
BUG: 379142
TEST PLAN
Compiles on gcc (as before) and on mingw. MSVC still to be tested.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5674
AFFECTED FILES
src/CMakeLists.txt
To: ltoscano, vonreth
Cc: #frameworks, #documentation, #windows, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170430/8ff533a6/attachment.html>
More information about the Kde-frameworks-devel
mailing list