D5638: Use a single QNAM (and a disk cache) for HTTP jobs
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Fri Apr 28 13:20:33 UTC 2017
leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use a single QNetworkAccessManager instance for all our HTTP jobs, and also add a simple diskcache to that qnam. Further ensure there is only a single qnam for the entire application using kns' http jobs, across all threads (lock when accessing the qnam). Without this, we are liable to end up creating and destroying a great many qnam instances, which certainly is something to try and avoid.
CCBUG: 379193
TEST PLAN
Using Discover, which creates a great many of these jobs, we have much less network traffic this way.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D5638
AFFECTED FILES
src/core/jobs/httpworker.cpp
To: leinir, whiting, apol
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170428/e4b6fc06/attachment.html>
More information about the Kde-frameworks-devel
mailing list