D5550: Fix property changes being missed immediately after an obejct is added

David Rosca noreply at phabricator.kde.org
Sun Apr 23 13:12:36 UTC 2017


drosca created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Fix race condition when property changes may be missed if the property
  is changed immediately after the object is created.
  The issue was that the connection to PropertyChanged signal was
  created only after interfacesAdded signal was fired, which may have
  already been too late.
  This fixes it with connecting to PropertyChanged signal on all paths
  in Manager::init().
  
  BUG: 377405

TEST PLAN
  Added test pass + old tests still pass

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5550

AFFECTED FILES
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/managertest.cpp
  autotests/managertest.h
  src/adapter_p.cpp
  src/device_p.cpp
  src/input.cpp
  src/input_p.h
  src/manager_p.cpp
  src/manager_p.h
  src/mediaplayer_p.cpp
  src/utils.cpp
  src/utils.h

To: drosca, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170423/5f844227/attachment.html>


More information about the Kde-frameworks-devel mailing list