D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

[Palo Kisa]

palokisa added a comment.


  >>>> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's not needed at all?
  >>> 
  >>> I don't know. I didn't investigate that.....I thought, it's some kind of "self-initializing" component and it is enough to link the library.
  >> 
  >> I don't think it's the case for KService (it is for KCrash though). Please investigate (or wait for feedback).
  > 
  > Then I believe, it's only some remnant, because it's not used anywhere in the code.
  
  
  
  > ... but looking at the fingerprints of packages (in debian), the libkf5crash5 is very light. So not real disadvantage to pull this dependency. So the KCoreAddons can be seen as more problematic dependency (from size point of view).
  
  Should I close this request and create a new one for the KF5::Service removal?

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170421/e088f893/attachment.html>