D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation
Luigi Toscano
noreply at phabricator.kde.org
Wed Apr 19 20:23:49 UTC 2017
ltoscano added inline comments.
INLINE COMMENTS
> main.cpp:68
> + QCoreApplication app(argc, argv);
> +
> KAboutData aboutData(QStringLiteral("baloo"), i18n("balooctl"), PROJECT_VERSION);
small nit: remove the whitespaces here
> main.cpp:39
> + QCoreApplication app(argc, argv);
> +
> KAboutData aboutData(QStringLiteral("Baloo"),
blanks here too
> main.cpp:56
> + QCoreApplication app(argc, argv);
> +
> KAboutData aboutData(QStringLiteral("balooshow"),
blanks
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5516
To: alexeymin, #frameworks, aacid, ltoscano
Cc: ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170419/39e512de/attachment.html>
More information about the Kde-frameworks-devel
mailing list