D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

Matthew Dawson noreply at phabricator.kde.org
Wed Apr 19 14:48:18 UTC 2017


mdawson added a comment.


  In https://phabricator.kde.org/D5502#103322, @wbauer wrote:
  
  > In https://phabricator.kde.org/D5502#103316, @mdawson wrote:
  >
  > > Can you please add some unit tests for this, to ensure it doesn't break in the future?  I think just three extra tests, one for a desktop file in a config directory, one in a data directory, and one present elsewhere would be enough.
  >
  >
  > Yes, I'll try.
  >  Though it will take till tomorrow I suppose...
  
  
  No problem, feel free to ask for help!  The tests can go in autotests/kdesktopfile.cpp, which already has several tests for KDesktopFile.  Take a look at the existing tests in that file for an example.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D5502

To: wbauer, #frameworks, mdawson
Cc: mdawson, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170419/c7c8e485/attachment.html>


More information about the Kde-frameworks-devel mailing list