D5506: Don't even try to create icons with empty sizes

Kevin Funk noreply at phabricator.kde.org
Wed Apr 19 12:14:03 UTC 2017


kfunk added inline comments.

INLINE COMMENTS

> kiconengine.cpp:87
>  
> -    if (!size.isValid()) {
> +    if (!size.isValid() || size.height() == 0 || size.width() == 0) {
>          return QPixmap();

`size.isEmpty()`?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D5506

To: apol, #frameworks
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170419/f811955d/attachment.html>


More information about the Kde-frameworks-devel mailing list