D5030: kioexec: delegate upload to a kded module

David Faure noreply at phabricator.kde.org
Sat Apr 15 08:14:53 UTC 2017


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Feel free to push after that last fix.

INLINE COMMENTS

> kioexecd.cpp:58
> +        qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" << info.fileName();
> +        QFile::remove(QFile::encodeName(it.key()));
> +        QDir().rmdir(parentDir);

QFile::remove takes a QString, this call to QFile::encodeName() is wrong and unnecessary.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5030

To: elvisangelaccio, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170415/da5fee46/attachment.html>


More information about the Kde-frameworks-devel mailing list