D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kossebau wrote in kaboutdata.h:314
> Why should it happen before? (sorry for being stubborn and curious here, I want to make sure to understand all code, to then also write proper warnings in the dox when needed, so people know they should not create it before).
> 
> The thing I understood Albert to point to yesterday was KMainWindow auto-filling the translator info in the application metadata (see KMainWindowPrivate::init(...), https://cgit.kde.org/kxmlgui.git/tree/src/kmainwindow.cpp#n239). But we also found that this actually has nothing to do with the Q*App instance vs. KAboutData instance (besides KMainWindow expecting the QApp instance to exist and KApplicationData::setAppData() having been called).
> The other mention was the TODO added by kf5/convert-kcmdlineargs.pl, 
> Sadly the commit which added that TODO does it only as side-effect and without any reasoning: https://cgit.kde.org/kde-dev-scripts.git/commit/kf5/convert-kcmdlineargs.pl?id=ac74bc07de810ef5a51a3030bfa96980f72ad8b1
> And from all code path I have seen there is nothing in the KAboutData constructor which requires a QApp instance. And the related i18n calls also are said nowhere said to require a QApp instance.
> @dfaure The above being your commit, do you remember (he, only 2 years ago ;) ) your motivation for that TODO?

The TODO in the porting script means : after running this script, perform this change by hand. This isn't unfinished code, it's just a reminder for the reader.

The rules given to us by the Qt developers are simple: do not use any parts of Qt that depend on locales before QCoreApplication is created.

So, do not create KAboutData before QCoreApplication is created. This isn't KDE4 anymore.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, aacid, ltoscano, mpyne
Cc: dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170415/7bfaa6ec/attachment.html>