D5345: Calendar: Use correct language for month and day names

Mark Gaiser noreply at phabricator.kde.org
Tue Apr 11 15:14:33 UTC 2017


markg added a comment.


  I'm just curious. Why is the day name determined in QML (in the lines you edited, but was there before as well) and on the C++ side?
  It smells like a redundancy.
  
  As far as i can tell (only looked for a moment), the dayName on the C++ side isn't used "in" the C++ side. It's sole purpose is to be used by QML.
  I'm fine with whatever you do though :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5345

To: drosca, #plasma, mck182
Cc: markg, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170411/ee4c5404/attachment.html>


More information about the Kde-frameworks-devel mailing list