D5329: Fix KActionSelectorPrivate::insertionIndex()

Anton Anikin noreply at phabricator.kde.org
Sat Apr 8 23:30:16 UTC 2017


antonanikin added a comment.


  > Is this really needed?
  >  Without your code it defaults to
  >  index = -1;
  >  what is the same as appending that is the same as atBottom, no?
  
  Yes, it needed - see here about negative index http://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/qlistwidget.cpp#n108

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D5329

To: antonanikin, #frameworks
Cc: aacid, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170408/75832e8a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list