Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.

Thanks, anyone else who wants to +1?

I've tried to test migration today but it didn't work. May as well have nothing to do with te patch and be caused by the permanently troubled migration agent though... KMail happily gets its IMAP password from kwallet5 though after manually export/import via XML files.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
-----------------------------------------------------------


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> -----------------------------------------------------------
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> These are not my own patches, I'm creating this review request after having been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I simply rebased on top of current master (author of course preserved) to be able to test it. I think it would be a great improvement over the current situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> -------
> 
> Migration itself was not tested so far, but a legacy application like ksirk was able to create a new wallet just fine and can access it as well. I do not have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170408/c14cf64e/attachment.html>