D5328: Ignore warnings during appdata generation

[Fabian Vogt]

fvogt created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  The Plasma/PopupApplet service type for example got deprecated and removed,
  but is still used by various parts of Plasma 5.8.
  This causes kpackagetool to emit warnings, but it still succeeds. However,
  this case is handled incorrectly as any stderr output is assumed to be critical
  and the file is not installed. As result is 0, no warning message is printed.
  
  This commit fixes this by ignoring the stderr output and using result to indicate
  success. Warning messages are printed if applicable.
  
  Major issue is that kpackagetool5 does not exit with an error if it encounters
  an error, so this installs a broken appdata file in some circumstances.
  
  BUG: 378529

TEST PLAN
  Built Plasma 5.8 with this patch. Works fine now.
  As warnings are now printed, it uncovered some little issues as well.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5328

AFFECTED FILES
  KF5PackageMacros.cmake

To: fvogt, mart, apol
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170407/c191a25c/attachment.html>